#21 Web uploader creates commits with unretrievable files

Closed
opened 5 years ago by jpgill86 · 5 comments

Steps to reproduce: Create a new repo, click the "Upload file" button, and upload and commit any test file, such as a plain text file.

Expected result: A commit should be created, and the file should be viewable and downloadable through the browser. I used this functionality a month ago on a forked repository and it worked as expected then.

Actual result:

Here is an example repo where I have done this already: https://web.gin.g-node.org/jpgill86/test-repo

The commit succeeds and creates an annex object file with MD5 content:

https://web.gin.g-node.org/jpgill86/test-repo/commit/f71f5238ee0bf377b26c537bf42ce1c81cce8197

I am not sure if this annex object file is what I should expect to see in the commit summary linked to above. I noticed that I don't see anything like that for my successful upload last month.

The file is shown in the file tree, but if you click on the file, you get a 500 Internal Server Error:

https://web.gin.g-node.org/jpgill86/test-repo/src/master/test-file.txt

An error has occurred : Could not find File: MD5-s18--304dbdc28f243c3da302271df3432fa6 anywhere below: /data/repos/jpgill86/test-repo.git/annex

I am primarily a Windows user, so I tried the WinGIN client to see if I could access the file that way. I can checkout the repo. If I right-click on the uploaded file, the "Gin Repository" context menu provides the "Download File" action. Clicking this or double-clicking the file directly causes an error prompt to open titled "Gin Service Error":

Gin Error! Error message is: [error] 1 operation failed

Am I misusing the service, or is there a problem here?

**Steps to reproduce:** Create a new repo, click the "Upload file" button, and upload and commit any test file, such as a plain text file. **Expected result:** A commit should be created, and the file should be viewable and downloadable through the browser. I used this functionality [a month ago](https://web.gin.g-node.org/jpgill86/ephy_testing_data/commit/58dddce82f6466473eaa55cbf2fbe16ad02a04e3) on a forked repository and it worked as expected then. **Actual result:** Here is an example repo where I have done this already: https://web.gin.g-node.org/jpgill86/test-repo The commit succeeds and creates an annex object file with MD5 content: https://web.gin.g-node.org/jpgill86/test-repo/commit/f71f5238ee0bf377b26c537bf42ce1c81cce8197 I am not sure if this annex object file is what I should expect to see in the commit summary linked to above. I noticed that I don't see anything like that for my successful upload [last month](https://web.gin.g-node.org/jpgill86/ephy_testing_data/commit/58dddce82f6466473eaa55cbf2fbe16ad02a04e3). The file is shown in the [file tree](https://web.gin.g-node.org/jpgill86/test-repo/src/f71f5238ee0bf377b26c537bf42ce1c81cce8197), but if you click on the file, you get a 500 Internal Server Error: https://web.gin.g-node.org/jpgill86/test-repo/src/master/test-file.txt An error has occurred : Could not find File: MD5-s18--304dbdc28f243c3da302271df3432fa6 anywhere below: /data/repos/jpgill86/test-repo.git/annex I am primarily a Windows user, so I tried the [WinGIN client](https://web.gin.g-node.org/G-Node/Info/wiki/WinGIN-Install) to see if I could access the file that way. I can checkout the repo. If I right-click on the uploaded file, the "Gin Repository" context menu provides the "Download File" action. Clicking this or double-clicking the file directly causes an error prompt to open titled "Gin Service Error": Gin Error! Error message is: [error] 1 operation failed Am I misusing the service, or is there a problem here?
Achilleas Koutsou commented 4 years ago
Owner

You're not misusing the service. It seems you've stumbled onto a pretty nasty bug that must have been introduced in the latest update. Thanks for the info. I'll have to fix this immediately.

You're not misusing the service. It seems you've stumbled onto a pretty nasty bug that must have been introduced in the latest update. Thanks for the info. I'll have to fix this immediately.
Achilleas Koutsou commented 4 years ago
Owner

It should be working now. Can you try uploading the same file and/or some other small files and checking if it's okay?

It should be working now. Can you try uploading the same file and/or some other small files and checking if it's okay?
Jeffrey Gill commented 4 years ago
Poster

You fixed it! I uploaded another copy of the same file with the same name, as well as a new file with a different name, and both worked as expected.

Thank you!

Is it normal for the commit process to take a full two minutes?

You fixed it! I uploaded another copy of the same file with the same name, as well as a new file with a different name, and both worked as expected. Thank you! Is it normal for the commit process to take a full two minutes?
Achilleas Koutsou commented 4 years ago
Owner

That issue is a bit more mysterious. It's certainly not normal. The commits are going through fast enough, but the response is taking too long, causing the browser loading to hang. It also occurs sometimes when pushing from the command line.

Thanks again for the report.

That issue is a bit more mysterious. It's certainly not normal. The commits are going through fast enough, but the response is taking too long, causing the browser loading to hang. It also occurs sometimes when pushing from the command line. Thanks again for the report.
Jeffrey Gill commented 4 years ago
Poster

I see what you mean. If I open a second browser tab to view the file tree immediately after pressing the commit button, I can see my new file is there. The browser tab that initiated the commit just doesn't receive a quick response from the server I guess.

Thanks for your very quick help!

I see what you mean. If I open a second browser tab to view the file tree immediately after pressing the commit button, I can see my new file is there. The browser tab that initiated the commit just doesn't receive a quick response from the server I guess. Thanks for your very quick help!
Sign in to join this conversation.
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.